Skip to content

removed legacy transaction map #5149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

asiegel-jt
Copy link
Contributor

No description provided.

@asiegel-jt asiegel-jt requested review from lidatong and jumpsiegel May 16, 2025 15:02
@asiegel-jt asiegel-jt self-assigned this May 16, 2025
jumpsiegel
jumpsiegel previously approved these changes May 16, 2025
/* For ledgers that contain txn status, decode and write out for solcap */
if( capture_ctx != NULL && capture_ctx->capture && capture_ctx->capture_txns && slot_ctx->slot_bank.slot>=capture_ctx->solcap_start_slot ) {
fd_runtime_write_transaction_status( capture_ctx, slot_ctx, txn_ctx, exec_txn_err );
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this functionality to debug BHM with solcap. Could we not remove this until we have it somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this feature works anyway. It depends on metadata being stored in the transaction map, which we generally don't do.

@asiegel-jt asiegel-jt force-pushed the asiegel/remove-txn-map branch from df56c72 to 8a6920f Compare May 19, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants